perf: marker rendering optimisations — memoize pilot and airport markers#18
Merged
Conversation
added 9 commits
April 8, 2026 19:17
… to cover badge colors
…, iconCacheVersion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PilotMarkersandAirportMarkersso unchanged markers cost near-zero reconciliation on every 20-second VATSIM data updatePilotMarkerItemsoReact.memogates the work — stationary pilots with unchanged aircraft/role skip re-render entirelyuseMemosogetAirportByCode,lookupTracon, and Skia image renders only run when data actually changesClusteredPilotMarkers) removedChanges
PilotMarkers.jsx— role/image resolution moved into child, filter+map memoized, named selector to fix Redux stability warningAirportMarkers.jsx— entire markers computation wrapped inuseMemo,onPressstabilized withuseCallbackLocalAirportMarker.jsx— customReact.memoequality comparator (checks atcList callsigns, traffic counts, theme)CTRPolygons.jsx—onPressstabilized withuseCallbackClusteredPilotMarkers.jsx— deleted (unused, stale implementation)__tests__/PilotMarkers.test.js— updated equality tests for new prop APITest Plan
Notes
Pure JS changes — no native modules touched. OTA-deployable.
Follow-up candidates (deferred): iOS marker rendering pipeline (child
<Image>→ nativeimageprop), viewport culling for high-density events.